I know why the two .wars are different:
The binary package Solr war's target chain is:
'package'->'create-package'->'dist'->'dist-war'->webapp:'dist'
The maven Solr war's target chain is:
'generate-maven-artifacts'->webapp:'dist-maven'->webapp:'dist'
So both create the war using webapp:'dist', but only 'dist-war' passes in a
modified 'exclude.from.war' property definition (which is empty by default):
<property name="exclude.from.war" value="*slf4j*,log4j-*" />
I think the fix is to make the above the default setting, rather than passing
in a non-default property value from 'dist-war'.
I'll make an issue.
Steve
On Apr 26, 2013, at 7:54 AM, Robert Muir <[email protected]> wrote:
> On Fri, Apr 26, 2013 at 7:50 AM, Yonik Seeley <[email protected]> wrote:
> On Fri, Apr 26, 2013 at 7:34 AM, Robert Muir <[email protected]> wrote:
> > I would try to help fix it: but its not clear to me which 'package' is
> > correct or what happened to logging at all in 4.3
>
> Solr's CHANGES has a summary:
>
> * Slf4j/logging jars are no longer included in the Solr webapp. All logging
> jars are now in example/lib/ext. Changing logging impls is now as easy as
> updating the jars in this folder with those necessary for the logging impl
> you would like. If you are using another webapp container, these jars will
> need to go in the corresponding location for that container.
> In conjunction, the dist-excl-slf4j and dist-war-excl-slf4 build targets
> have been removed since they are redundent. See the Slf4j documentation,
> SOLR-3706, and SOLR-4651 for more details.
>
>
> As i said, this means the war in the TGZ is broken (and does not really
> work). And we still have the problem the war in maven disagrees with all
> this and does in fact contain the .jars.
>
> So it all looks like a disaster to me.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
