Thanks for fixing this Mike!

On 29 April 2013 00:29, Michael McCandless <luc...@mikemccandless.com>wrote:

> Ahh sneaky ... this has tripped us up before.  I just committed a fix
> to RIW to not doRandomForceMerge when NoMergePolicy is in use.
>
> Thanks Martijn!
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Sun, Apr 28, 2013 at 4:36 PM, Uwe Schindler <u...@thetaphi.de> wrote:
> > Ah,
> >
> >
> >
> > we have other tests that also set nomerge policy. So RandomIndexWriter
> > checks what happens if you call forceMerge? This should be a noop for
> this
> > merge policy?
> >
> >
> >
> > Uwe
> >
> >
> >
> > -----
> >
> > Uwe Schindler
> >
> > H.-H.-Meier-Allee 63, D-28213 Bremen
> >
> > http://www.thetaphi.de
> >
> > eMail: u...@thetaphi.de
> >
> >
> >
> > From: martijn.is.h...@gmail.com [mailto:martijn.is.h...@gmail.com] On
> Behalf
> > Of Martijn v Groningen
> > Sent: Sunday, April 28, 2013 8:34 PM
> > To: dev@lucene.apache.org
> > Subject: Re: [JENKINS] Lucene-Solr-4.x-Linux (32bit/ibm-j9-jdk6) - Build
> #
> > 5334 - Failure!
> >
> >
> >
> > I looked into a previous failure of this test and committed a fix for
> that.
> > I think that fix caused this failure. In the fix I use of the
> NoMergePolicy
> > and this seems to break the assert in the
> > RandomIndexWriter#doRandomForceMerge() method.
> >
> >
> >
> > On 28 April 2013 19:17, Michael McCandless <luc...@mikemccandless.com>
> > wrote:
> >
> > I think Martijn is looking into it?
> > Mike McCandless
> >
> > http://blog.mikemccandless.com
> >
> >
> >
> > On Sun, Apr 28, 2013 at 11:34 AM, Uwe Schindler <u...@thetaphi.de> wrote:
> >> This one reproduces with Oracle JDK 6 or 7, 32 or 64 bit. It is not an
> J9
> >> issue, it's a real bug!
> >>
> >> Uwe
> >>
> >> -----
> >> Uwe Schindler
> >> H.-H.-Meier-Allee 63, D-28213 Bremen
> >> http://www.thetaphi.de
> >> eMail: u...@thetaphi.de
> >>
> >>> -----Original Message-----
> >>> From: Policeman Jenkins Server [mailto:jenk...@thetaphi.de]
> >>> Sent: Sunday, April 28, 2013 5:19 PM
> >>> To: dev@lucene.apache.org; u...@thetaphi.de
> >>> Subject: [JENKINS] Lucene-Solr-4.x-Linux (32bit/ibm-j9-jdk6) - Build #
> >>> 5334 -
> >>> Failure!
> >>>
> >>> Build: http://jenkins.thetaphi.de/job/Lucene-Solr-4.x-Linux/5334/
> >>> Java: 32bit/ibm-j9-jdk6
> >>>
> >>> 1 tests failed.
> >>> REGRESSION:
> >>> org.apache.lucene.search.join.TestBlockJoinSorting.testNestedSorting
> >>>
> >>> Error Message:
> >>> limit=2 actual=4
> >>>
> >>> Stack Trace:
> >>> java.lang.AssertionError: limit=2 actual=4
> >>>       at
> >>> __randomizedtesting.SeedInfo.seed([51EE345C29BF7C40:5907D91D6916712E
> >>> ]:0)
> >>>       at
> >>> org.apache.lucene.index.RandomIndexWriter.doRandomForceMerge(Rando
> >>> mIndexWriter.java:293)
> >>>       at
> >>> org.apache.lucene.index.RandomIndexWriter.close(RandomIndexWriter.jav
> >>> a:336)
> >>>       at
> >>>
> >>>
> org.apache.lucene.search.join.TestBlockJoinSorting.testNestedSorting(TestB
> >>> lockJoinSorting.java:212)
> >>>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >>>       at
> >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.j
> >>> ava:60)
> >>>       at
> >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> >>> sorImpl.java:37)
> >>>       at java.lang.reflect.Method.invoke(Method.java:611)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(Randomize
> >>> dRunner.java:1559)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner.access$600(Rando
> >>> mizedRunner.java:79)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(Rando
> >>> mizedRunner.java:737)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(Rando
> >>> mizedRunner.java:773)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(Rando
> >>> mizedRunner.java:787)
> >>>       at
> >>> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRule
> >>> SetupTeardownChained.java:50)
> >>>       at
> >>>
> >>>
> org.apache.lucene.util.TestRuleFieldCacheSanity$1.evaluate(TestRuleFieldCa
> >>> cheSanity.java:51)
> >>>       at
> >>>
> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeA
> >>> fterRule.java:46)
> >>>       at
> >>>
> com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1
> >>> .evaluate(SystemPropertiesInvariantRule.java:55)
> >>>       at
> >>> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleTh
> >>> readAndTestName.java:49)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRule
> >>> IgnoreAfterMaxFailures.java:70)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure
> >>> .java:48)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stat
> >>> ementAdapter.java:36)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.
> >>> run(ThreadLeakControl.java:358)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask
> >>> (ThreadLeakControl.java:782)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadL
> >>> eakControl.java:442)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(Ran
> >>> domizedRunner.java:746)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(Rando
> >>> mizedRunner.java:648)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(Rando
> >>> mizedRunner.java:682)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(Rando
> >>> mizedRunner.java:693)
> >>>       at
> >>>
> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeA
> >>> fterRule.java:46)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreCl
> >>> assName.java:42)
> >>>       at
> >>>
> com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1
> >>> .evaluate(SystemPropertiesInvariantRule.java:55)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMet
> >>> hodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMet
> >>> hodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stat
> >>> ementAdapter.java:36)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAss
> >>> ertionsRequired.java:43)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure
> >>> .java:48)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRule
> >>> IgnoreAfterMaxFailures.java:70)
> >>>       at
> >>>
> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnore
> >>> TestSuites.java:55)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(Stat
> >>> ementAdapter.java:36)
> >>>       at
> >>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.
> >>> run(ThreadLeakControl.java:358)
> >>>       at java.lang.Thread.run(Thread.java:738)
> >>>
> >>>
> >>>
> >>>
> >>> Build Log:
> >>> [...truncated 6696 lines...]
> >>> [junit4:junit4] Suite:
> org.apache.lucene.search.join.TestBlockJoinSorting
> >>> [junit4:junit4]   2> NOTE: reproduce with: ant test  -
> >>> Dtestcase=TestBlockJoinSorting -Dtests.method=testNestedSorting -
> >>> Dtests.seed=51EE345C29BF7C40 -Dtests.multiplier=3 -Dtests.slow=true -
> >>> Dtests.locale=mk_MK -Dtests.timezone=Europe/Belfast -
> >>> Dtests.file.encoding=UTF-8
> >>> [junit4:junit4] FAILURE 0.50s J0 |
> TestBlockJoinSorting.testNestedSorting
> >>> <<<
> >>> [junit4:junit4]    > Throwable #1: java.lang.AssertionError: limit=2
> >>> actual=4
> >>> [junit4:junit4]    >  at
> >>> __randomizedtesting.SeedInfo.seed([51EE345C29BF7C40:5907D91D6916712E
> >>> ]:0)
> >>> [junit4:junit4]    >  at
> >>> org.apache.lucene.index.RandomIndexWriter.doRandomForceMerge(Rando
> >>> mIndexWriter.java:293)
> >>> [junit4:junit4]    >  at
> >>> org.apache.lucene.index.RandomIndexWriter.close(RandomIndexWriter.jav
> >>> a:336)
> >>> [junit4:junit4]    >  at
> >>>
> >>>
> org.apache.lucene.search.join.TestBlockJoinSorting.testNestedSorting(TestB
> >>> lockJoinSorting.java:212)
> >>> [junit4:junit4]    >  at java.lang.Thread.run(Thread.java:738)
> >>> [junit4:junit4]   2> NOTE: test params are: codec=Appending,
> >>> sim=RandomSimilarityProvider(queryNorm=false,coord=no): {},
> >>> locale=mk_MK, timezone=Europe/Belfast
> >>> [junit4:junit4]   2> NOTE: Linux 3.2.0-40-generic x86/IBM Corporation
> >>> 1.6.0
> >>> (32-bit)/cpus=8,threads=1,free=3710224,total=12267008
> >>> [junit4:junit4]   2> NOTE: All tests run in this JVM:
> >>> [TestBlockJoinSorting]
> >>> [junit4:junit4] Completed on J0 in 0.81s, 1 test, 1 failure <<<
> FAILURES!
> >>>
> >>> [...truncated 16 lines...]
> >>> BUILD FAILED
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/build.xml:384: The
> >>> following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/build.xml:377: The
> >>> following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/build.xml:39: The
> >>> following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/build.xml:548:
> >>> The following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/common-
> >>> build.xml:1800: The following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/module-
> >>> build.xml:61: The following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/common-
> >>> build.xml:1243: The following error occurred while executing this line:
> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/common-
> >>> build.xml:887: There were test failures: 3 suites, 15 tests, 1 failure
> >>>
> >>> Total time: 20 minutes 15 seconds
> >>> Build step 'Invoke Ant' marked build as failure Description set: Java:
> >>> 32bit/ibm-j9-jdk6 Archiving artifacts Recording test results Email was
> >>> triggered for: Failure Sending email for trigger: Failure
> >>>
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: dev-h...@lucene.apache.org
> >
> >
> >
> >
> >
> > --
> > Met vriendelijke groet,
> >
> > Martijn van Groningen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>


-- 
Met vriendelijke groet,

Martijn van Groningen

Reply via email to