[
https://issues.apache.org/jira/browse/LUCENE-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4972:
-------------------------------
Attachment: LUCENE-4972.patch
Patch adds isDirty flag to DTW and tests. I think it's ready, but would
appreciate a review.
> DirectoryTaxonomyWriter makes a commit even if no changes were made
> -------------------------------------------------------------------
>
> Key: LUCENE-4972
> URL: https://issues.apache.org/jira/browse/LUCENE-4972
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-4972.patch
>
>
> Now that IndexWriter allows committing changes even if the only change is
> setCommitData, DirectoryTaxonomyWriter creates empty commits because whenever
> you call commit/close, it sets as commitData the indexEpoch, thereby creating
> unnecessary commit points.
> I think that DirTaxoWriter should track if the index is dirty ... or
> preferably get that from IndexWriter (i.e. getChangeCount or something). I'll
> create a test case exposing the bug and then fix DTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
