I commited a fix for SOLR-4803 so that the solr example is now working nicely again and the smoke tests against it pass. but i'm still seeing failures (on trunk, didn't try 4x) because evidently the NOTICE file checks have been broken...

     [exec]   File "/home/hossman/lucene/dev/dev-tools/scripts/smokeTestRelease.py", 
line 1383, in <module>
     [exec]     main()
     [exec]   File 
"/home/hossman/lucene/dev/dev-tools/scripts/smokeTestRelease.py", line 1327, in 
main
     [exec]     smokeTest(baseURL, svnRevision, version, tmpDir, isSigned)
     [exec]   File 
"/home/hossman/lucene/dev/dev-tools/scripts/smokeTestRelease.py", line 1372, in 
smokeTest
     [exec]     unpackAndVerify('solr', tmpDir, 'solr-%s-src.tgz' % version, 
svnRevision, version)
     [exec]   File 
"/home/hossman/lucene/dev/dev-tools/scripts/smokeTestRelease.py", line 595, in 
unpackAndVerify
     [exec]     verifyUnpacked(project, artifact, unpackPath, svnRevision, 
version, tmpDir)
     [exec]   File 
"/home/hossman/lucene/dev/dev-tools/scripts/smokeTestRelease.py", line 716, in 
verifyUnpacked
     [exec]     testNotice(unpackPath)
     [exec]   File 
"/home/hossman/lucene/dev/dev-tools/scripts/smokeTestRelease.py", line 758, in 
testNotice
     [exec]     raise RuntimeError('Solr\'s NOTICE.txt does not have the 
verbatim copy, plus header/footer, of Lucene\'s NOTICE.txt')
     [exec] RuntimeError: Solr's NOTICE.txt does not have the verbatim copy, 
plus header/footer, of Lucene's NOTICE.txt
     [exec]     check NOTICE

I think the problem is this change?

http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/NOTICE.txt?r1=1478785&r2=1478784&pathrev=1478785

...but i'm out of time to keep trying to commit changes and then run nightly-smoke before my vacation, so i'm hoping omeone else can look into this.

(I vaguely remember there being good reasons not to generate the Solr NOTICE.txt just by catting the lucene NOTICE.txt onto the end of a solr specific header, but is there any reason we can't updated "ant precommit" to catch this?)


-Hoss

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to