[ https://issues.apache.org/jira/browse/SOLR-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653316#comment-13653316 ]
Mark Miller commented on SOLR-4655: ----------------------------------- bq. I don't think the test can ever pass without a split actually happening That's what really surprised me - that i could get any pass based on that missing code - but I didn't look closely enough. I can probably remove those lines again by looking at the patch you originally commented on and see if I can reproduce it. > The Overseer should assign node names by default. > ------------------------------------------------- > > Key: SOLR-4655 > URL: https://issues.apache.org/jira/browse/SOLR-4655 > Project: Solr > Issue Type: Improvement > Components: SolrCloud > Reporter: Mark Miller > Assignee: Mark Miller > Fix For: 4.3, 5.0 > > Attachments: SOLR-4655.patch, SOLR-4655.patch, SOLR-4655.patch, > SOLR-4655.patch, SOLR-4655.patch, SOLR-4655.patch > > > Currently we make a unique node name by using the host address as part of the > name. This means that if you want a node with a new address to take over, the > node name is misleading. It's best if you set custom names for each node > before starting your cluster. This is cumbersome though, and cannot currently > be done with the collections API. Instead, the overseer could assign a more > generic name such as nodeN by default. Then you can easily swap in another > node with no pre planning and no confusion in the name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org