[ 
https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658577#comment-13658577
 ] 

Steve Rowe commented on LUCENE-4981:
------------------------------------

bq. So I don't really think this is a use-case for PositionFilter?

I agree, subclassing the QP and overriding {{newFieldQuery}} and 
{{getFieldQuery}} should be sufficient to handle this use case.  Current 
PositionFilter users will have to maintain their own code outside of Lucene and 
Solr's codebase, rather than having a configuration-only solution.

I think the {{@deprecated}} annotation on PositionFilter in branch_4x should be 
augmented to help people find this alternative.  Similarly, in the backcompat 
section of trunk CHANGES.txt, and/or MIGRATE.txt, this issue should be 
mentioned.

                
> Deprecate PositionFilter
> ------------------------
>
>                 Key: LUCENE-4981
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4981
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4981.patch
>
>
> According to the documentation 
> (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory),
>  PositionFilter is mainly useful to make query parsers generate boolean 
> queries instead of phrase queries although this problem can be solved at 
> query parsing level instead of analysis level (eg. using 
> QueryParser.setAutoGeneratePhraseQueries).
> So given that PositionFilter corrupts token graphs (see TestRandomChains), I 
> propose to deprecate it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to