[ 
https://issues.apache.org/jira/browse/SOLR-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659117#comment-13659117
 ] 

Hoss Man commented on SOLR-4825:
--------------------------------

after commit r1483088 on trunk (and likewise on 4x), RegexBoostProcessorTest 
started failing because the testframework detected that the static variabls in 
the test were using too much ram.

as i noted via email...

{noformat}
Something is fishy with this sudden onset of RegexBoostProcessorTest 
failures....

 - happening on diff hosts, diff OSes, diff JVMs
 - happening on trunk and 4x
 - only started happening today
 - SolrRequestParsers object is huge for no explicible reason...

: Stack Trace: junit.framework.AssertionFailedError: Clean up static 
: fields (in @AfterClass?), your test seems to hang on to approximately 
: 51,150,032 bytes (threshold is 10,485,760). Field reference sizes 
: (counted individually):
        ...
:   - 51,880,376 bytes, protected static 
: org.apache.solr.servlet.SolrRequestParsers 
: org.apache.solr.update.processor.RegexBoostProcessorTest._parser

...why is SolrRequestParsers 51 MB ?

In other similar failures today it was 11MB, 12MB, 25MB, etc...

Instances of this class shouldn't by fluctuating in size, it doesn't 
maintain any mutable state -- so WTF?

Don't get me wrong: RegexBoostProcessorTest should probably have an 
@AfterClass to null this out -- but i'm concerned that either:

a) something has changed allowing SolrRequestParsers instances to now 
grow w/o bound

b) something has changed to break the size detection code in the test 
framework.
{noformat}

rmuir "fixed" the test to null out the SolrRequestParsers instance in the test, 
but also noted that when he was debugging things...

{noformat}
I think it might be related to its logger actually.

When i run it before mark's commit on SOLR-4825, its logger is 50kb
when i run it now, its logger is megabytes.

So I think that change caused it
{noformat}

...so there definitely smells like a memory leak in here somewhere.
                
> Port SolrLogFormatter to log4j
> ------------------------------
>
>                 Key: SOLR-4825
>                 URL: https://issues.apache.org/jira/browse/SOLR-4825
>             Project: Solr
>          Issue Type: Test
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Critical
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4825.patch
>
>
> Cloud tests are extremelly difficult to debug without this logging - can't go 
> back to the early days of sys outs at this point. I'll port this formatter to 
> work with log4j as a Layout.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to