[
https://issues.apache.org/jira/browse/SOLR-4823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
philip hoy updated SOLR-4823:
-----------------------------
Attachment: SOLR-4823.patch
Here is a first stab at a refactorig, it is without any additional test
coverage at present and may well be a bit to much to swallow. However I am
happy to revisit it. Interestingly moving the cloud load balancing code out of
LBHttpSolrServer did not affect any tests so perhaps that use case could use
some extra test coverage.
> Split LBHttpSolrServer into two classes one for the solrj use case and one
> for the solr cloud use case
> ------------------------------------------------------------------------------------------------------
>
> Key: SOLR-4823
> URL: https://issues.apache.org/jira/browse/SOLR-4823
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: philip hoy
> Priority: Minor
> Attachments: SOLR-4823.patch
>
>
> The LBHttpSolrServer has too many responsibilities. It could perhaps be
> broken into two classes, one in solrj to be used in the place of an external
> load balancer that balances across a known set of solr servers defined at
> construction time and one in solr core to be used by the solr cloud
> components that balances across servers dependant on the request.
> To save code duplication, if much arises an abstract bass class could be
> introduced in to solrj.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
