I have backported LUCENE-4949 to the 4.3 branch.
On Wed, May 15, 2013 at 9:00 PM, Uwe Schindler <u...@thetaphi.de> wrote: > Hi, > > ok, I just wanted to be sure! > > > I double checked (also 3.6.1, 3.6.2, and 4.2.1 releases): hossman's > commit is > > correct actually. > > > > This is the one used for back compat (its tested with the version > > comparator), but its just marking which version of lucene wrote the > > segment. The variable name should really be changed, "MAIN" says nothing. > > > > This one is the more important one though: another reason why its not > > triggered by the version sysprop from build.xml: our comparator cannot > deal > > with any -SNAPSHOT or any maven suffixes or any of that horseshit. it > needs > > real version numbers. > > In trunk and branch_4x we already changed the numbering in common-build to > fix some bugs with Jenkins! We have now: > <property name="dev.version.base" value="4.4"/> > We should maybe backport this commit to 4.3, too. > > So we can use this to maybe check consistency or pass this version somehow > to tests. > > Our version comparator can handle those versions, so it expands missing > parts with ".0", so e.g. "4.3.1" is considered greater than "4.3" (which is > treated as "4.3.0"). > > > On Wed, May 15, 2013 at 7:57 AM, Robert Muir <rcm...@gmail.com> wrote: > > > On Wed, May 15, 2013 at 4:23 AM, Uwe Schindler <u...@thetaphi.de> > > wrote: > > >> Are we sure that this is the right thing? The LUCENE_MAIN_VERSION is > > used for index compatibility and should always be only in X.Y format. > > >> > > >> Please revert this! > > >> > > > > > > Uwe is correct: please only adjust build.xml here or whatever, but > > > don't change this! > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional > > commands, e-mail: dev-h...@lucene.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > -- Regards, Shalin Shekhar Mangar.
