[ 
https://issues.apache.org/jira/browse/SOLR-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662253#comment-13662253
 ] 

Shawn Heisey commented on SOLR-4788:
------------------------------------

A review of all Solr issues that mention last_index_time turns up SOLR-4051 
(via SOLR-1970) as a possible candidate for the commit that broke this 
functionality.  This assumes of course that it worked after the feature was 
added by SOLR-783, which is probably a safe assumption.

SOLR-4051 says that it patches functionality that was introduced to 3.6.  I 
think that was added by SOLR-2382, so it might have been SOLR-2382 that broke 
things.

If I get some time in the near future I will attempt to write a test that 
illustrates the bug, and see if I can run that test on 3.6 as well.  If anyone 
out there can try a manual test on 3.6, that would save some time.

Side note: the code uses two constants for "last_index_time" - LAST_INDEX_TIME 
and LAST_INDEX_KEY.  Those should probably be combined.

                
> Multiple Entities DIH delta import: dataimporter.[entityName].last_index_time 
> is empty
> --------------------------------------------------------------------------------------
>
>                 Key: SOLR-4788
>                 URL: https://issues.apache.org/jira/browse/SOLR-4788
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.2, 4.3
>         Environment: solr-spec
> 4.2.1.2013.03.26.08.26.55
> solr-impl
> 4.2.1 1461071 - mark - 2013-03-26 08:26:55
> lucene-spec
> 4.2.1
> lucene-impl
> 4.2.1 1461071 - mark - 2013-03-26 08:23:34
> OR
> solr-spec
> 4.3.0
> solr-impl
> 4.3.0 1477023 - simonw - 2013-04-29 15:10:12
> lucene-spec
> 4.3.0
> lucene-impl
> 4.3.0 1477023 - simonw - 2013-04-29 14:55:14
>            Reporter: chakming wong
>            Assignee: Shalin Shekhar Mangar
>
> {code:title=conf/dataimport.properties|borderStyle=solid}entity1.last_index_time=2013-05-06
>  03\:02\:06
> last_index_time=2013-05-06 03\:05\:22
> entity2.last_index_time=2013-05-06 03\:03\:14
> entity3.last_index_time=2013-05-06 03\:05\:22
> {code}
> {code:title=conf/solrconfig.xml|borderStyle=solid}<?xml version="1.0" 
> encoding="UTF-8" ?>
> ...
>     <requestHandler name="/dataimport" 
> class="org.apache.solr.handler.dataimport.DataImportHandler">
>         <lst name="defaults">
>             <str name="config">dihconfig.xml</str>
>         </lst>
>     </requestHandler>
> ...
> {code}
> {code:title=conf/dihconfig.xml|borderStyle=solid}<?xml version="1.0" 
> encoding="UTF-8" ?>
> <dataConfig>
>     <dataSource name="source1"
>                 type="JdbcDataSource" driver="com.mysql.jdbc.Driver"
>                 url="jdbc:mysql://*:*/*"
>                 user="*" password="*"/>
>     <document name="strings">
>         <entity name="entity1" pk="id" dataSource="source1"
>                 query="SELECT * FROM table_a"
>                 deltaQuery="SELECT table_a_id FROM table_b WHERE 
> last_modified > '${dataimporter.entity1.last_index_time}'"
>                 deltaImportQuery="SELECT * FROM table_a WHERE id = 
> '${dataimporter.entity1.id}'"
>                 transformer="TemplateTransformer">
>             <field> ...
>               ... 
>             ... </field>
>         </entity>
>         <entity name="entity2">
>               ... 
>               ...
>         </entity>
>         <entity name="entity3">
>               ... 
>               ...
>         </entity>
>     </document>
> </dataConfig>
> {code} 
> In above setup, *dataimporter.entity1.last_index_time* is *empty string* and 
> cause the sql query having error

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to