[
https://issues.apache.org/jira/browse/LUCENE-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670200#comment-13670200
]
Gilad Barkai commented on LUCENE-5016:
--------------------------------------
Patch looks good.
+1 for commit
> Sampling can break FacetResult labeling
> ----------------------------------------
>
> Key: LUCENE-5016
> URL: https://issues.apache.org/jira/browse/LUCENE-5016
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 4.3
> Reporter: Rob Audenaerde
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-5016.patch, test-labels.zip
>
>
> When sampling FacetResults, the TopKInEachNodeHandler is used to get the
> FacetResults.
> This is my case:
> A FacetResult is returned (which matches a FacetRequest) from the
> StandardFacetAccumulator. The facet has 0 results. The labelling of the
> root-node seems incorrect. I know, from the StandardFacetAccumulator, that
> the rootnode has a label, so I can use that one.
> Currently the recursivelyLabel method uses the taxonomyReader.getPath() to
> retrieve the label. I think we can skip that for the rootNode when there are
> no children (and gain a little performance on the way too?)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
