[
https://issues.apache.org/jira/browse/SOLR-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683443#comment-13683443
]
Benson Margulies commented on SOLR-4872:
----------------------------------------
Originally, Hoss documented some disquiet with using SolrCoreAware. If I add
you two together and divide, I come up with the following proposal ...
# what you can see in the patch so far; a mechanism to get lifecycle awareness
into the schema object.
# instead of a close method on the factories, allow them to implement a new
interface, SchemaComponentLifecycle. This would achieve Hoss' goal of avoiding
tangling schema and core. Then IndexSchema would invoke via this interface upon
schema teardown.
Ultimately, I have to navigate amongst you all, so I will await further
exchange of views.
> Allow schema analysis object factories to be cleaned up properly when the
> core shuts down
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-4872
> URL: https://issues.apache.org/jira/browse/SOLR-4872
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.3
> Reporter: Benson Margulies
> Attachments: solr-4872.patch, solr-4872.patch
>
>
> I have a need, in an TokenizerFactory or TokenFilterFactory, to have a shared
> cache that is cleaned up when the core is torn down.
> There is no 'close' protocol on these things, and Solr rejects analysis
> components that are SolrCoreAware.
> Possible solutions:
> # add a close protocol to these factories and make sure it gets called at
> core shutdown.
> # allow these items to be 'core-aware'.
> # invent some notion of 'schema-lifecycle-aware'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
