[ https://issues.apache.org/jira/browse/SOLR-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690484#comment-13690484 ]
Erick Erickson commented on SOLR-4948: -------------------------------------- If you can fix up the nonsense about whether or not there's a cfg in core container that's null that appears to _only_ be true in the test shell you would have my eternal gratitude. There are a series of comments around if (cfg != null) {do one thing} else { do another}. I really, really _hate_ having the main-line code have conditions that are only there for testing, but never tried to take on fixing the test-harness sensitivites. Haven't reviewed quite yet, may be able to this weekend. > Tidy up CoreContainer construction logic > ---------------------------------------- > > Key: SOLR-4948 > URL: https://issues.apache.org/jira/browse/SOLR-4948 > Project: Solr > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Minor > Attachments: SOLR-4948.patch > > > While writing tests for SOLR-4914, I discovered that it's *really difficult* > to create a CoreContainer. There are a bunch of constructors which > initialise different things, one (but only one!) of which also loads all the > cores. Then you have the Initializer object, which basically does the same > thing. Sort of. And then the TestHarness doesn't actually use > CoreContainer, but an anonymous subclass of CoreContainer which has it's own > initialisation logic. It would be nice to clean this up! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org