[
https://issues.apache.org/jira/browse/SOLR-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694307#comment-13694307
]
Hoss Man commented on SOLR-4892:
--------------------------------
+1 ... code looks good.
two minor things i didn't notice before...
a) i think there's some class javadoc cut/paste mistakes ... if you grep the
patch for "solr.ParseDoubleFieldUpdateProcessorFactory" it shows up in the
class jdocs for several other factories.
b) the logic in ParseBooleanFieldUpdateProcessorFactory could probably be a
little simpler/faster if there was a single {{Map<String,Boolean>}} instead of
two {{Set<String>}} that each had to be checked.
> Add field update processors to parse/convert String-typed fields to Date,
> Number, and Boolean
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-4892
> URL: https://issues.apache.org/jira/browse/SOLR-4892
> Project: Solr
> Issue Type: New Feature
> Components: update
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Priority: Minor
> Fix For: 4.4
>
> Attachments: SOLR-4892.patch, SOLR-4892.patch
>
>
> Add {{FieldMutatingUpdateProcessorFactory}} subclasses
> {{ParseFooUpdateProcessorFactory}}, where {{Foo}} includes {{Date}},
> {{Double}}, {{Long}}, and {{Boolean}}.
> These factories will have a default selector that matches all fields that
> either don’t match any schema field, or are in the schema with the
> corresponding {{typeClass}}. They can optionally support a list of multiple
> format specifiers. If they see a value that is not a CharSequence, or can't
> parse the value using a configured format, they ignore it and leave it as is.
> For multi-valued fields, these processors will not convert any values unless
> all are first successfully parsed. Ordering the processors [Boolean, Long,
> Double, Date] will allow e.g. values [2, 5, 8.6] to be left alone by the
> Boolean and Long processors, but then converted by the Double processor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
