[ 
https://issues.apache.org/jira/browse/SOLR-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701318#comment-13701318
 ] 

Uwe Schindler commented on SOLR-4948:
-------------------------------------

Thanks Alan, I will help you on any problems! I hope SOLR-5009 is obvious, why 
it is a bad idea to lazyly create SolrResourceLoaders. As Erick said, this 
might be the issue for the recent permgen issues on trunk!

Currently I am investigating all other places where Solr creates 
SolrResourceLoader but does not close it. The only remaining part is 
SolrCore.reload(), I have to figure out if the old Core is correctly closed and 
also closes the ResourceLoader!
                
> Tidy up CoreContainer construction logic
> ----------------------------------------
>
>                 Key: SOLR-4948
>                 URL: https://issues.apache.org/jira/browse/SOLR-4948
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch, 
> SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch
>
>
> While writing tests for SOLR-4914, I discovered that it's *really difficult* 
> to create a CoreContainer.  There are a bunch of constructors which 
> initialise different things, one (but only one!) of which also loads all the 
> cores.  Then you have the Initializer object, which basically does the same 
> thing.  Sort of.  And then the TestHarness doesn't actually use 
> CoreContainer, but an anonymous subclass of CoreContainer which has it's own 
> initialisation logic.  It would be nice to clean this up!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to