[ 
https://issues.apache.org/jira/browse/SOLR-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-4916:
-----------------------------

    Attachment: 
SOLR-4916-move-MiniDfsCluster-deps-from-solr-test-framework-to-solr-core.patch

bq. My best idea would be to add a second lib folder 
(test-framework/runtime-libs) that is not packed into the binary ZIP file 
distribution. It's easy to add: We can add a separate resolve with another 
target folder. In Maven it should also definitely not be listed as dependency 
for runtime, too!

{quote}
bq. My vote is to move the deps to solr-core.

+1. Like test-only in Maven, for IVY, I would put them into a separate config 
and store in a separate directory, so they are not packaged: 
{{solr/core/test-libs}}
{quote}

This patch moves the MiniDfsCluster dependencies from 
{{solr/test-framework/ivy.xml}} to {{solr/core/ivy.xml}}, using a separate Ivy 
configuration, and storing the deps in {{solr/core/test-lib/}}.  I also took 
the opportunity to store other test jars there: easymock and its deps.  As a 
result, we no longer need exceptions for these test-only deps when pulling from 
{{solr/core/lib/}} to put into the war.

The patch also gives DIH the same treatment for easymock -> 
{{solr/contrib/dataimporthandler/test-lib/}} - previously DIH got that test dep 
via {{solr/core/lib/}}.

The patch includes Ant/Ivy, IntelliJ, Maven, and Eclipse support for the 
dependency moves.  I successfully ran Solr tests under each of those, except 
Eclipse, which I don't use.

I want to include this change in 4.4, so that we don't ship Maven config for 
solr test-framework with dependencies on solr-core-only test deps.
                
> Add support to write and read Solr index files and transaction log files to 
> and from HDFS.
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4916
>                 URL: https://issues.apache.org/jira/browse/SOLR-4916
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4916-ivy.patch, 
> SOLR-4916-move-MiniDfsCluster-deps-from-solr-test-framework-to-solr-core.patch,
>  SOLR-4916.patch, SOLR-4916.patch, SOLR-4916.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to