[ 
https://issues.apache.org/jira/browse/LUCENE-5100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-5100:
---------------------------------

    Attachment: LUCENE-5100.patch

Thanks for the explanation, Robert. I tried to factorize some code between 
TestFixedBitSet and TestOpenBitSet by adding an abstraction level on top of 
both FixedBitSet and OpenBitSet but its complexity made the tests even harder 
to read, so I think I won't touch the prevSetBit/nextSetBit/flip/... tests and 
just add the tests from {{BaseDcIdSetTestCase}}.

Updated patch. The modification in EliasFanoEncoder is here to always be able 
to pass {{maxDoc - 1}} as an upper bound even when the set is empty (an 
assertion would trip otherwise). I think it is ready?
                
> BaseDocIdSetTestCase
> --------------------
>
>                 Key: LUCENE-5100
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5100
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>         Attachments: LUCENE-5100.patch, LUCENE-5100.patch
>
>
> As Robert said on LUCENE-5081, we would benefit from having common testing 
> infrastructure for our DocIdSet implementations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to