[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706697#comment-13706697
]
Dawid Weiss edited comment on LUCENE-5098 at 7/12/13 6:35 AM:
--------------------------------------------------------------
bq. I don't really like using LuceneTestCase here because the tests here pass
when extending TestCase and they do not use anything that LuceneTestCase
provides
If you prefer not to have that discussion here I will shut up. I just wanted to
clarify that LTC does checks on your test that you bypass when you extend from
TestCase. Randomization of method order (catches order dependencies that
shouldn't be there), ensuring your tests run with assertions enabled, checking
if your tests don't spawn extra threads -- all these (and more) may not matter
to you because you're a seasoned engineer but they do matter in general when
contributions come from various sources (or are refactored later by people
other than the original author). Randomization isn't the only goal of LTC.
In short: it's not a remark to you personally, it's a remark to everyone in
general that extending LTC should be a priority because it will catch faulty
tests faster.
was (Author: dweiss):
bq. I don't really like using LuceneTestCase here because the tests here
pass when extending TestCase and they do not use anything that LuceneTestCase
provides
If you prefer not to have that discussion here I will shut up. I just wanted to
clarify that LTC does checks on your test that you bypass when you extend from
TestCase. Randomization of method order (catches order dependencies that
shouldn't be there), ensuring your tests run with assertions enabled, checking
if your threads don't spawn extra threads -- all these (and more) may not
matter to you because you're a seasoned engineer but they do matter in general
when contributions come from various sources. Randomization isn't the only goal
of LTC.
In short: it's not a remark to you personally, it's a remark to everyone in
general that extending LTC should be a priority because it will catch faulty
tests faster.
> Broadword bit selection
> -----------------------
>
> Key: LUCENE-5098
> URL: https://issues.apache.org/jira/browse/LUCENE-5098
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Paul Elschot
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5098.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
