[ 
https://issues.apache.org/jira/browse/SOLR-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709520#comment-13709520
 ] 

Amit Nithian commented on SOLR-4310:
------------------------------------

While it's been a few months since I looked at this patch (and unfortunately I 
don't work with Solr much anymore), I think the patch should be good to go 
insofar as the unit tests I submitted passes. Is there anything I can do to 
help get this moving along?
                
> If groups.ngroups is specified, the docList's numFound should be the number 
> of groups
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-4310
>                 URL: https://issues.apache.org/jira/browse/SOLR-4310
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 4.1
>            Reporter: Amit Nithian
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 4.4
>
>         Attachments: SOLR-4310_2.patch, SOLR-4310_3.patch, SOLR-4310.patch
>
>
> If you group by a field, the response may look like this:
> <lst name="grouped">
> <lst name="series">
> <int name="matches">138</int>
> <int name="ngroups">1</int>
> <result name="doclist" numFound="138" start="0">
> <doc>
> <int name="id">267038365</int>
> <str name="name">
> Larry's Grand Ole Garage Country Dance - Pure Country
> </str>
> </doc>
> </result>
> </lst>
> </lst>
> and if you specify group.main then the doclist becomes the result and you 
> lose all context of the number of groups. If you want to keep your response 
> format backwards compatible with clients (i.e. clients who don't know about 
> the grouped format), setting group.main=true solves this BUT the numFound is 
> the number of raw matches instead of the number of groups. This may have 
> downstream consequences.
> I'd like to propose that if the user specifies ngroups=true then when 
> creating the returning DocSlice, set the numFound to be the number of groups 
> instead of the number of raw matches to keep the response consistent with 
> what the user would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to