[
https://issues.apache.org/jira/browse/SOLR-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717517#comment-13717517
]
Mark Miller edited comment on SOLR-4998 at 7/23/13 7:36 PM:
------------------------------------------------------------
I think for things like:
{noformat}
- public static final String MAX_SHARDS_PER_NODE = "maxShardsPerNode";
+ public static final String MAX_REPLICAS_PER_NODE = "maxReplicasPerNode";
{noformat}
We have to be really careful. Solr does not error/warn on unknown params -
existing users might keeping using the existing param for a long time, and not
even notice it no longer has an affect. I think if we make any type of change
like that, we should be sure to support them as an alias or perhaps explicitly
look for the old key and fail if it's found.
was (Author: markrmil...@gmail.com):
I think for things like:
- public static final String MAX_SHARDS_PER_NODE = "maxShardsPerNode";
+ public static final String MAX_REPLICAS_PER_NODE = "maxReplicasPerNode";
We have to be really careful. Solr does not error/warn on unknown params -
existing users might keeping using the existing param for a long time, and not
even notice it no longer has an affect. I think if we make any type of change
like that, we should be sure to support them as an alias or perhaps explicitly
look for the old key and fail if it's found.
> Make the use of Slice and Shard consistent across the code and document base
> ----------------------------------------------------------------------------
>
> Key: SOLR-4998
> URL: https://issues.apache.org/jira/browse/SOLR-4998
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 4.3, 4.3.1
> Reporter: Anshum Gupta
> Attachments: SOLR-4998.patch
>
>
> The interchangeable use of Slice and Shard is pretty confusing at times. We
> should define each separately and use the apt term whenever we do so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
