[ https://issues.apache.org/jira/browse/LUCENE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718272#comment-13718272 ]
Uwe Schindler commented on LUCENE-4335: --------------------------------------- bq. Ill back out the jenkins check, merge this to trunk, and open a new issue. Can you provide a patch here, I just wanted to have a quick look! Otherwise if we leave out jenkins from the game at the moment and fix that in later issues and talk with [~steve_rowe] about releasing or forking JFlex. The Moan stuff should maybe downloaded as a ZIP file from the specific HG version (e.g. from Bitbucket as ZIP file using the commit hash) and unzipped. > Builds should regenerate all generated sources > ---------------------------------------------- > > Key: LUCENE-4335 > URL: https://issues.apache.org/jira/browse/LUCENE-4335 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Attachments: LUCENE-4335.patch, LUCENE-4335.patch > > > We have more and more sources that are generated programmatically (query > parsers, fuzzy levN tables from Moman, packed ints specialized decoders, > etc.), and it's dangerous because developers may directly edit the generated > sources and forget to edit the meta-source. It's happened to me several > times ... most recently just after landing the BlockPostingsFormat branch. > I think we should re-gen all of these in our builds and fail the build if > this creates a difference. I know some generators (eg JavaCC) embed > timestamps and so always create mods ... we can leave them out of this for > starters (or maybe post-process the sources to remove the timestamps) ... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org