[ https://issues.apache.org/jira/browse/LUCENE-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722498#comment-13722498 ]
Shai Erera commented on LUCENE-5144: ------------------------------------ Tests pass, if there are no objections, I intend to commit this shortly. > Nuke FacetRequest.createAggregator > ---------------------------------- > > Key: LUCENE-5144 > URL: https://issues.apache.org/jira/browse/LUCENE-5144 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Shai Erera > Assignee: Shai Erera > Attachments: LUCENE-5144.patch > > > Aggregator was replaced by FacetsAggregator. FacetRequest has > createAggregator() which by default throws an UOE. It was left there until we > migrate the aggregators to FacetsAggregator -- now all of our requests > support FacetsAggregator. > Aggregator is used only by StandardFacetsAccumulator, which too needs to > vanish, at some point. But it currently it's the only one which handles > sampling, complements aggregation and partitions. > What I'd like to do is remove FacetRequest.createAggregator and in > StandardFacetsAccumulator support only CountFacetRequest and > SumScoreFacetRequest, which are the only ones that make sense for sampling > and partitions. SumScore does not even support complements (which only work > for counting). > I'll also rename StandardFA to OldStandardFA. The plan is to eventually > implement a SamplingAccumulator, PartitionsAccumulator/Aggregator and > ComplementsAggregator, removing that class entirely. Until then ... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org