[ 
https://issues.apache.org/jira/browse/LUCENE-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738143#comment-13738143
 ] 

Uwe Schindler edited comment on LUCENE-5170 at 8/13/13 12:39 PM:
-----------------------------------------------------------------

The definition of the strategy pattern can be found here, no state involved: 
http://en.wikipedia.org/wiki/Strategy_pattern
                
      was (Author: thetaphi):
    The strategy pattern is defined like this, no state involved: 
http://en.wikipedia.org/wiki/Strategy_pattern
                  
> Add getter for reuse strategy to Analyzer, make AnalyzerWrapper's reuse 
> strategy configureable
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5170
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5170
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other, modules/analysis
>    Affects Versions: 4.4
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.0, 4.5
>
>         Attachments: LUCENE-5170.patch
>
>
> If you write an Analyzer that wraps another one (but without using 
> AnalyzerWrapper) you may need use the same reuse strategy in your wrapper. 
> This is not possible as there is no way to get the reuse startegy (private 
> field and no getter).
> An example is ES's NamedAnalyzer, see my comment: 
> [https://github.com/elasticsearch/elasticsearch/commit/b9a2fbd8741aa1b9beffb7d2922fc9b4525397e4#src/main/java/org/elasticsearch/index/analysis/NamedAnalyzer.java]
> This would add a getter, just a 3-liner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to