[ 
https://issues.apache.org/jira/browse/LUCENE-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739675#comment-13739675
 ] 

Robert Muir commented on LUCENE-5170:
-------------------------------------

+1

Thanks for cleaning this up!
                
> Add getter for reuse strategy to Analyzer, make AnalyzerWrapper's reuse 
> strategy configureable, fix strategy to be stateless
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5170
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5170
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other, modules/analysis
>    Affects Versions: 4.4
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.0, 4.5
>
>         Attachments: LUCENE-5170.patch, LUCENE-5170.patch, LUCENE-5170.patch, 
> LUCENE-5170.patch
>
>
> If you write an Analyzer that wraps another one (but without using 
> AnalyzerWrapper) you may need use the same reuse strategy in your wrapper. 
> This is not possible as there is no way to get the reuse startegy (private 
> field and no getter).
> An example is ES's NamedAnalyzer, see my comment: 
> [https://github.com/elasticsearch/elasticsearch/commit/b9a2fbd8741aa1b9beffb7d2922fc9b4525397e4#src/main/java/org/elasticsearch/index/analysis/NamedAnalyzer.java]
> This would add a getter, just a 3-liner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to