[
https://issues.apache.org/jira/browse/LUCENE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741140#comment-13741140
]
Robert Muir commented on LUCENE-5166:
-------------------------------------
Manuel: your fix is correct, thank you.
To explain: I had totally forgotten about this little loop on tf within the
passage (i had removed this optimization in LUCENE-4909, which didnt turn out
to work that great, so wasn't committed).
We might at some point want to still just remove the optimization just based on
the reason that it makes this thing more complicated, it was just intended to
speed up the worst case (where someone has very common stopwords and stuff like
that).
But for now to complete the bugfix, we should commit your patch
(LUCENE-5166-revisited.patch).
> PostingsHighlighter fails with IndexOutOfBoundsException
> --------------------------------------------------------
>
> Key: LUCENE-5166
> URL: https://issues.apache.org/jira/browse/LUCENE-5166
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/highlighter
> Affects Versions: 4.4
> Reporter: Manuel Amoabeng
> Fix For: 5.0, 4.5
>
> Attachments: LUCENE-5166-2.patch, LUCENE-5166.patch,
> LUCENE-5166.patch, LUCENE-5166.patch, LUCENE-5166.patch, LUCENE-5166.patch,
> LUCENE-5166.patch, LUCENE-5166-revisited.patch
>
>
> Given a document with a match at a startIndex < PostingsHighlighter.maxlength
> and an endIndex > PostingsHighlighter.maxLength, DefaultPassageFormatter will
> throw an IndexOutOfBoundsException when DefaultPassageFormatter.append() is
> invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
