[
https://issues.apache.org/jira/browse/LUCENE-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741514#comment-13741514
]
Robert Muir commented on LUCENE-5177:
-------------------------------------
I don't think we should hang "fieldcaches" directly off readers.
Fieldcache is a broken design: users who want to sort/facet on a field should
index their content correctly with docvalues instead.
Its fine for it to be wrapped underneath an UninvertingFilterReader, that also
takes a Map<String,DocValuesType> up front though, but by no means should we
have this broken shit tightly coupled with stuff in lucene/core
> remove fieldcache weakmap or at least see what relies on GC for purging today
> -----------------------------------------------------------------------------
>
> Key: LUCENE-5177
> URL: https://issues.apache.org/jira/browse/LUCENE-5177
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Robert Muir
> Attachments: LUCENE-5177.patch
>
>
> If we are registering close listeners why does this need to be weak?
> But really i dont care about that, here is what i said to Hoss on the solr
> mailing list:
> {quote}
> > (In any case: it looks like a WeakHashMap is still used in case the
> > listeners never get called, correct?)
> >
> I think it might be the other way around: i think it was weakmap
> before always, the close listeners were then added sometime in 3.x
> series, so we registered purge events "as an optimization".
> But one way to look at it is: readers should really get closed, so why
> have the weak map and not just a regular hashmap.
> Even if we want to keep the weak map (seriously i dont care, and i
> dont want to be the guy fielding complaints on this), I'm going to
> open with an issue with a patch that removes it and fails tests in
> @afterclass if there is any entries. This way its totally clear
> if/when/where anything is "relying on GC" today here and we can at
> least look at that.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
