[ 
https://issues.apache.org/jira/browse/LUCENE-5148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747532#comment-13747532
 ] 

Robert Muir commented on LUCENE-5148:
-------------------------------------

Right: I'm still convinced the trap only impacts committers writing unit tests 
that compare against slow-wrappers :)

The patch seems to have a very large amount of changes for such a small 
thing... is there some reformatting happening?

If we can't implement this without major changes: then I dont think we should 
do it.
                
> SortedSetDocValues caching / state
> ----------------------------------
>
>                 Key: LUCENE-5148
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5148
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5148.patch
>
>
> I just spent some time digging into a bug which was due to the fact that 
> SORTED_SET doc values are stateful (setDocument/nextOrd) and are cached per 
> thread. So if you try to get two instances from the same field in the same 
> thread, you will actually get the same instance and won't be able to iterate 
> over ords of two documents in parallel.
> This is not necessarily a bug, this behavior can be documented, but I think 
> it would be nice if the API could prevent from such mistakes by storing the 
> state in a separate object or cloning the SortedSetDocValues object in 
> SegmentCoreReaders.getSortedSetDocValues?
> What do you think?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to