[ 
https://issues.apache.org/jira/browse/SOLR-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750208#comment-13750208
 ] 

Mark Miller commented on SOLR-4817:
-----------------------------------

bq. I suspect that most of the default solr.xml was actually used by tests, and 
often not by intention...

Many of the tests were written before solr.xml existed - the built in solr.xml 
was included for back compat on those pre existing installs. Because it worked 
with back compat, the people that added solr.xml did not have to update all the 
tests at the time - something that's commonly done.

I think that is totally okay though, because we are here to do it now that it 
actually must be done for 5.0 :) It's actually probably simpler to deal with 
now than it was back then.
                
> Solr should not fall back to the back compat built in solr.xml in SolrCloud 
> mode.
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4817
>                 URL: https://issues.apache.org/jira/browse/SOLR-4817
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch, 
> SOLR-4817.patch, SOLR-4817.patch
>
>
> A hard error is much more useful, and this built in solr.xml is not very good 
> for solrcloud - with the old style solr.xml with cores in it, you won't have 
> persistence and with the new style, it's not really ideal either.
> I think it makes it easier to debug solr.home to fail on this instead - but 
> just in solrcloud mode for now due to back compat. We might want to pull the 
> whole internal solr.xml for 5.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to