[ 
https://issues.apache.org/jira/browse/SOLR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762543#comment-13762543
 ] 

Yonik Seeley commented on SOLR-2548:
------------------------------------

bq. in the event of an exception in one worker; the rest should be cancelled

In addition to Robert's comment that points out why we never want to use cancel 
on anything that does IO, we shouldn't add complexity trying to optimize an 
error case.

bq. ExecutionException is a wrapping exception; you should unwrap it and wrap 
SolrException on its contents, not the ExecutionException itself.

We should definitely strive to make the multi-threading as transparent as 
possible (i.e. exceptions should be as close as possible to the non-threaded 
case).
                
> Multithreaded faceting
> ----------------------
>
>                 Key: SOLR-2548
>                 URL: https://issues.apache.org/jira/browse/SOLR-2548
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1
>            Reporter: Janne Majaranta
>            Assignee: Erick Erickson
>            Priority: Minor
>              Labels: facet
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-2548_4.2.1.patch, SOLR-2548_for_31x.patch, 
> SOLR-2548_multithreaded_faceting,_dsmiley.patch, SOLR-2548.patch, 
> SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, 
> SOLR-2548.patch
>
>
> Add multithreading support for faceting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to