[ 
https://issues.apache.org/jira/browse/LUCENE-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771282#comment-13771282
 ] 

ASF subversion and git services commented on LUCENE-5220:
---------------------------------------------------------

Commit 1524588 from [~rcmuir] in branch 'dev/trunk'
[ https://svn.apache.org/r1524588 ]

LUCENE-5220: ExpressionSortField has crappy toString/bad equals/hashcode
                
> Expression SortField has crappy toString/bad equals/hashcode
> ------------------------------------------------------------
>
>                 Key: LUCENE-5220
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5220
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.6
>            Reporter: Robert Muir
>         Attachments: LUCENE-5220.patch
>
>
> While doing some unrelated debugging:
> I noticed when printing the Sort, the expressions get the inherited toString 
> for a CUSTOM comparator, which is not very good:
> {noformat}
> <custom:"sqrt(_score) + ln(popularity)": null>!
> {noformat}
> I think its better if it looks something like this instead:
> {noformat}
> <expr "sqrt(_score) + ln(popularity)">!
> {noformat}
> Also equals/hashcode is wrong: it will bogusly report equals(true) if the 
> expression is the same: but bindings could be different!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to