[ https://issues.apache.org/jira/browse/LUCENE-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771418#comment-13771418 ]
Robert Muir commented on LUCENE-5219: ------------------------------------- This patch looks great to me. Can you fix the javadocs for parse()? In this case its pretty obvious which exception happens for what, so its ok to remove the throws elements, or just add some short description (e.g. IOException if there was problem reading the file, ParseException if its syntactically incorrect, etc) FYI: You can check the javadocs by doing 'ant documentation-lint': {noformat} -ecj-javadoc-lint-src: [ecj-lint] Compiling 365 source files [ecj-lint] ---------- [ecj-lint] 1. ERROR in /home/rmuir/workspace/lucene-clean-trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMap.java (at line 303) [ecj-lint] * @throws IOException [ecj-lint] ^^^^^^^^^^^ [ecj-lint] Javadoc: Description expected after this reference [ecj-lint] ---------- [ecj-lint] 2. ERROR in /home/rmuir/workspace/lucene-clean-trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMap.java (at line 304) [ecj-lint] * @throws ParseException [ecj-lint] ^^^^^^^^^^^^^^ [ecj-lint] Javadoc: Description expected after this reference [ecj-lint] ---------- [ecj-lint] 2 problems (2 errors) {noformat} > Make SynonymFilterFactory format attribute pluggable > ---------------------------------------------------- > > Key: LUCENE-5219 > URL: https://issues.apache.org/jira/browse/LUCENE-5219 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Ryan Ernst > Attachments: LUCENE-5219.patch > > > It would be great to allow custom synonym formats to work with > SynonymFilterFactory. There is already a comment in the code to make it > pluggable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org