Robert Muir created LUCENE-5229:
-----------------------------------

             Summary: remove Collector specializations
                 Key: LUCENE-5229
                 URL: https://issues.apache.org/jira/browse/LUCENE-5229
             Project: Lucene - Core
          Issue Type: Bug
            Reporter: Robert Muir
            Assignee: Robert Muir


There are too many collector specializations (i think 16 or 18?) and too many 
crazy defaults like returning NaN scores to the user by default in 
indexsearcher.

this confuses hotspot (I will ignore any benchmarks posted here where only one 
type of sort is running thru the JVM, thats unrealistic), and confuses users 
with stuff like NaN scores coming back by default.

I have two concerete suggestions:

* nuke doMaxScores. its implicit from doScores. This is just over the top. This 
should also halve the collectors.
* change doScores to true by default in indexsearcher. since shai was confused 
by the NaNs by default, and he added this stuff to lucene, that says 
*everything* about how wrong this default is. Someone who *does* understand 
what it does can simply pass false.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to