[ 
https://issues.apache.org/jira/browse/LUCENE-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773721#comment-13773721
 ] 

Shai Erera commented on LUCENE-5232:
------------------------------------

Maybe we can fix the API by making maxScore private on TopDocs, and throw 
IllegalStateException if you call it, yet it's NaN? I think it's an overkill 
though and it's enough to document that that's the behavior if you don't ask to 
compute maxScore.
                
> Remove doMaxScore from indexsearcher, collector specializations, etc
> --------------------------------------------------------------------
>
>                 Key: LUCENE-5232
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5232
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>             Fix For: 5.0
>
>
> I think we should just compute doMaxScore whenever doDocScores = true.
> This would remove 4 collector specializations and remove a boolean parameter 
> from 4 indexsearcher methods.
> We can just do this in 5.0 I think.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to