[
https://issues.apache.org/jira/browse/SOLR-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Heisey updated SOLR-5264:
-------------------------------
Attachment: SOLR-5264.patch
Attaching patch. I'm sure there's a lot to not like about it, so I'd like
comments in two areas. 1) Is the general idea sound? 2) What specifically
could be done better?
It did occur to me that the more generic method I mentioned in the TODO would
in fact be the best approach right up front. That would name the method
removeCollection instead of removeArgsCollection, returning Collection<Object>.
It would then be up to the caller to decide what object types constitute an
error condition. Thoughts?
> New method on NamedList to return one or many config arguments as collection
> ----------------------------------------------------------------------------
>
> Key: SOLR-5264
> URL: https://issues.apache.org/jira/browse/SOLR-5264
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.5
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 5.0, 4.6
>
> Attachments: SOLR-5264.patch
>
>
> In the FieldMutatingUpdateProcessorFactory is a method called "oneOrMany"
> that takes all of the entries in a NamedList and pulls them out into a
> Collection. I'd like to use that in a custom update processor I'm building.
> It seems as though this functionality would be right at home as part of
> NamedList itself. Here's a patch that moves the method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
