[
https://issues.apache.org/jira/browse/SOLR-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781351#comment-13781351
]
Shawn Heisey commented on SOLR-5264:
------------------------------------
Thanks for the feedback.
* I like your idea of having removeAll and removeArgs mention each other in the
javadoc. I'll do that.
* I was really struggling trying to find a good name instead of removeArgs that
wasn't horribly long, finally just decided to make it short. I'm open to
suggestions in that department. The best alternative I've thought up so far is
removeConfigArgs, which is more descriptive of its typical usage. I'm inclined
to make that change unless there's strong objection.
* Point taken on removal in 5.0 instead of a later 4.x release. That will be
noted in the javadoc. Am I right in thinking that it's better to make an
additional trunk commit to remove the method, rather than start in 4x and merge
to trunk?
> New method on NamedList to return one or many config arguments as collection
> ----------------------------------------------------------------------------
>
> Key: SOLR-5264
> URL: https://issues.apache.org/jira/browse/SOLR-5264
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.5
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 5.0, 4.6
>
> Attachments: SOLR-5264.patch, SOLR-5264.patch, SOLR-5264.patch,
> SOLR-5264.patch
>
>
> In the FieldMutatingUpdateProcessorFactory is a method called "oneOrMany"
> that takes all of the entries in a NamedList and pulls them out into a
> Collection. I'd like to use that in a custom update processor I'm building.
> It seems as though this functionality would be right at home as part of
> NamedList itself. Here's a patch that moves the method.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
