[
https://issues.apache.org/jira/browse/LUCENE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781479#comment-13781479
]
Robert Muir commented on LUCENE-5240:
-------------------------------------
solr doesnt support highlighting trie fields... so its really not used at all
today.
In my opinion this tokenizer just causes us to scratch our heads all the time
and thats it, no benefits just wasting of committers time :)
I am happy to also only remove it in trunk, i dont care. for 4.x i could just
svn revert the changes to Tokenizer.java but still backport all the fixes in
the patch.
> additional safety in Tokenizer state machine
> --------------------------------------------
>
> Key: LUCENE-5240
> URL: https://issues.apache.org/jira/browse/LUCENE-5240
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5240.patch, LUCENE-5240.patch, LUCENE-5240.patch
>
>
> {code}
> * <b>NOTE:</b>
> * The default implementation closes the input Reader, so
> * be sure to call <code>super.close()</code> when overriding this method.
> */
> @Override
> public void close() throws IOException {
> {code}
> We can add a simple check for this easily now in setReader. I found a few
> bugs, and fixed all except TrieTokenizer in solr (I am lost here... somewhere
> i have a patch to remove this thing).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
