[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781868#comment-13781868
]
Shai Erera commented on LUCENE-5189:
------------------------------------
I don't mind if we backport the whole thing in one commit. Just thought it will
be cleaner to backport each issue's commits. I doubt anyone would "hit" an
issue within the couple of hours it will take. But I'll do this in one backport.
bq. Only port stuff to the stable branch unless you'd be happy to release it
tomorrow
I agree, though what if we decide to release 5.0 in one month? Do we revert the
whole feature? I just think that it's software, and software always improves.
Even if we optimize the way updates are kept (the problem is in
ReaderAndLiveDocs), it can always be improved tomorrow even more. That's why
the feature is marked @lucene.experimental -- it may not be the most optimized
thing, but it works and more importantly - it doesn't affect users that don't
use it ("do no harm").
I will look into improving the way updates are kept in RALD
(Map<String,Map<Integer,Long>>), though honestly, we have no data points as to
whether it's efficient or not, or whether the new structure is more efficient.
What I think we can do is keep the updates in conceptually an int[] and long[]
pair arrays (maybe one of those **Buffer we have for better compression). I'll
start w/ that.
> Numeric DocValues Updates
> -------------------------
>
> Key: LUCENE-5189
> URL: https://issues.apache.org/jira/browse/LUCENE-5189
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5189-4x.patch, LUCENE-5189.patch,
> LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch,
> LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch,
> LUCENE-5189.patch, LUCENE-5189.patch
>
>
> In LUCENE-4258 we started to work on incremental field updates, however the
> amount of changes are immense and hard to follow/consume. The reason is that
> we targeted postings, stored fields, DV etc., all from the get go.
> I'd like to start afresh here, with numeric-dv-field updates only. There are
> a couple of reasons to that:
> * NumericDV fields should be easier to update, if e.g. we write all the
> values of all the documents in a segment for the updated field (similar to
> how livedocs work, and previously norms).
> * It's a fairly contained issue, attempting to handle just one data type to
> update, yet requires many changes to core code which will also be useful for
> updating other data types.
> * It has value in and on itself, and we don't need to allow updating all the
> data types in Lucene at once ... we can do that gradually.
> I have some working patch already which I'll upload next, explaining the
> changes.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
