[ 
https://issues.apache.org/jira/browse/LUCENE-5291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798108#comment-13798108
 ] 

Erick Erickson commented on LUCENE-5291:
----------------------------------------

Please feel totally free to attach a patch, no matter whether you think it's 
"finished" or not. Yonik's law of patches:

"A half-baked patch with no documentation, no tests and no backwards 
compatibility is better than no patch at all."

That let's people really see what changes you've made, make recommendations, 
etc.

Two requests:
1> make sure of the formatting. See 
http://wiki.apache.org/solr/HowToContribute. That page links to format files 
for Eclipse and IntelliJ files.
2> label your patch LUCENE-5291.patch. If you put up successive patches, give 
them the same name. The newest one will gray-out the older ones, making it very 
easy to both see the history and get the most recent

And thanks! This is now open source code gets better!

> Faster Query-Time Join
> ----------------------
>
>                 Key: LUCENE-5291
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5291
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index, core/search
>    Affects Versions: 4.5
>            Reporter: Erik Groeneveld
>            Priority: Minor
>              Labels: join, query
>
> The current implementation of query-time join could be complemented with a 
> much faster one, provided some choices can be made about what to join on.
> Since join is really a database concept, we found it quite natural to 
> restrict the keys to be integers and be single valued. 
> We found that if it is possible to use integers keys, and having single 
> valued key fields, the speed of join can be improved 50 fold. Proper caching 
> again speeds up about 20 times.
> I'd like to contribute our code if you agree that it is a useful 
> contribution.  That probably depends on what you think of the choices we made 
> about the keys, so that need to be discussed first?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to