[
https://issues.apache.org/jira/browse/LUCENE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798121#comment-13798121
]
Paul Elschot commented on LUCENE-3229:
--------------------------------------
The patch of 16 Oct 2013 works for me.
Is there any reason for some of methods in TestNearSpansOrdered to be protected?
I made the following change to try and make it a bit more involved.
The subquery is now not ordered, and its arguments have been reversed:
{code}
protected SpanNearQuery makeOverlappedQuery() {
return new SpanNearQuery(
new SpanQuery[] {
new SpanNearQuery(new SpanQuery[] {
new SpanTermQuery(new Term(FIELD, "w5")),
new SpanTermQuery(new Term(FIELD, "w3")) },
1,
false
),
new SpanTermQuery(new Term(FIELD, "w4")) },
0,
true);
}
{code}
The only thing I can think of that might be in the way is that this changes
existing behaviour, and it does not provide any way to have the previous
behaviour.
Using unordered spans does allow overlaps, so that does not have to be real
problem, and it isn't for me.
Any objections because of the lack of backward compatibility?
> SpanNearQuery: ordered spans should not overlap
> -----------------------------------------------
>
> Key: LUCENE-3229
> URL: https://issues.apache.org/jira/browse/LUCENE-3229
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Affects Versions: 3.1
> Environment: Windows XP, Java 1.6
> Reporter: ludovic Boutros
> Fix For: 4.6
>
> Attachments: LUCENE-3229.patch, LUCENE-3229.patch, LUCENE-3229.patch,
> SpanOverlap2.diff, SpanOverlap.diff, SpanOverlapTestUnit.diff
>
>
> While using Span queries I think I've found a little bug.
> With a document like this (from the TestNearSpansOrdered unit test) :
> "w1 w2 w3 w4 w5"
> If I try to search for this span query :
> spanNear([spanNear([field:w3, field:w5], 1, true), field:w4], 0, true)
> the above document is returned and I think it should not because 'w4' is not
> after 'w5'.
> The 2 spans are not ordered, because there is an overlap.
> I will add a test patch in the TestNearSpansOrdered unit test.
> I will add a patch to solve this issue too.
> Basicaly it modifies the two docSpansOrdered functions to make sure that the
> spans does not overlap.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
