[ 
https://issues.apache.org/jira/browse/LUCENE-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799130#comment-13799130
 ] 

Paul Elschot commented on LUCENE-5293:
--------------------------------------

bq. I don't like much having support for specific filters based on instanceof 
calls.
Me neither, but that can be fixed by adding a docFreq() method to DocIdSet, as 
another hint to be used by CachingWrapperFilter.
This method should return the actual number of doc ids in the set when its 
return value >= 0.

The existing hint in DocIdSet is isCacheable(), its javadocs will need to 
updated since they need not mention BitSet anymore.

I also prefer option 2, but I'd like to avoid using the other filter impl when 
possible by using the docFreq hint.

I'll try and make another patch for this.


> Also use EliasFanoDocIdSet in CachingWrapperFilter
> --------------------------------------------------
>
>                 Key: LUCENE-5293
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5293
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Paul Elschot
>            Priority: Minor
>         Attachments: LUCENE-5293.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to