[ https://issues.apache.org/jira/browse/LUCENE-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand updated LUCENE-5301: --------------------------------- Attachment: LUCENE-5301.patch New patch: PackedInts.Reader now only extends NumericDocValues. > All PackedInts APIs should share a common interface for random-access reads > --------------------------------------------------------------------------- > > Key: LUCENE-5301 > URL: https://issues.apache.org/jira/browse/LUCENE-5301 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Attachments: LUCENE-5301.patch, LUCENE-5301.patch > > > It would be convenient if all PackedInts had a super-class with the {{long > get(long index)}} method. Maybe this super-class could even be > NumericDocValues so that doc values formats don't need to wrap eg. > BlockPackedReader into this kind of construct: > {code} > final BlockPackedReader reader = new BlockPackedReader(data, > entry.packedIntsVersion, entry.blockSize, entry.count, true); > return new LongNumericDocValues() { > @Override > public long get(long id) { > return reader.get(id); > } > }; > {code} > Instead, they could just > {code} > return new BlockPackedReader(data, entry.packedIntsVersion, > entry.blockSize, entry.count, true); > {code} -- This message was sent by Atlassian JIRA (v6.1#6144) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org