[
https://issues.apache.org/jira/browse/SOLR-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820523#comment-13820523
]
Ryan Ernst commented on SOLR-5399:
----------------------------------
This looks very useful for debugging distributed requests!
A couple minor thoughts on the patch:
* It looks like there is a typo "tack" vs track, in DebugComponentTest.
* In testModifyRequestTrack() and testPrepare(), it would be nice to add a loop
so a couple variations can be tested in a single test run (just less reliance
on jenkins coming up with seeds that will hit possible bugs).
* The REQUEST_PURPOSE parameter name is in CamelCase, but it seems like the
other request parameters are lowercase. Maybe make it match stylistically?
+1 in general though.
> Improve DebugComponent for distributed requests
> -----------------------------------------------
>
> Key: SOLR-5399
> URL: https://issues.apache.org/jira/browse/SOLR-5399
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Attachments: SOLR-5399.patch, SOLR-5399.patch
>
>
> I'm working on extending the DebugComponent for adding some useful
> information to be able to track distributed requests better. I'm adding two
> different things, first, the request can generate a "request ID" that will be
> printed in the logs for the main query and all the different internal
> requests to the different shards. This should make it easier to find the
> different parts of a single user request in the logs. It would also add the
> "purpose" of each internal request to the logs, like:
> RequestPurpose=GET_FIELDS,GET_DEBUG or RequestPurpose=GET_TOP_IDS.
> Also, I'm adding a "track" section to the debug info where to add information
> about the different phases of the distributed request (right now, I'm only
> including QTime, but could eventually include more information) like:
> {code:xml}
> <lst name="debug">
> <lst name="track">
> <lst name="EXECUTE_QUERY">
> <str name="localhost:8985/solr">QTime: 10</str>
> <str name="localhost:8984/solr">QTime: 25</str>
> </lst>
> <lst name="GET_FIELDS">
> <str name="localhost:8985/solr">QTime: 1</str>
> </lst>
> </lst>
> </lst>
> {code}
> To get this, debugQuery must be set to true, or debug must include
> "debug=track". This information is only added to distributed requests. I
> would like to get feedback on this.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
