[
https://issues.apache.org/jira/browse/LUCENE-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829431#comment-13829431
]
Uwe Schindler edited comment on LUCENE-5347 at 11/21/13 10:48 PM:
------------------------------------------------------------------
Because there was an error in commons-io signatures, some violations were not
detected with 1.3:
{noformat}
-check-forbidden-base:
[forbidden-apis] Reading bundled API signatures: jdk-unsafe-1.7
[forbidden-apis] Reading bundled API signatures: jdk-deprecated-1.7
[forbidden-apis] Reading bundled API signatures: commons-io-unsafe-2.1
[forbidden-apis] Reading API signatures: C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr3\lucene\tools\forbiddenApis\base.txt
[forbidden-apis] Reading API signatures: C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr3\lucene\tools\forbiddenApis\servlet-api.txt
[forbidden-apis] Loading classes to check...
[forbidden-apis] Scanning for API signatures and dependencies...
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses default charset]
[forbidden-apis] in org.apache.solr.handler.admin.ShowFileRequestHandler
(ShowFileRequestHandler.java:426)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses default charset]
[forbidden-apis] in org.apache.solr.handler.admin.ShowFileRequestHandler
(ShowFileRequestHandler.java:450)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses default charset]
[forbidden-apis] in org.apache.solr.core.TestLazyCores
(TestLazyCores.java:582)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#readFileToString(java.io.File) [Uses default
charset]
[forbidden-apis] in org.apache.solr.handler.PingRequestHandlerTest
(PingRequestHandlerTest.java:103)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses default charset]
[forbidden-apis] in org.apache.solr.AnalysisAfterCoreReloadTest
(AnalysisAfterCoreReloadTest.java:124)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#readFileToString(java.io.File) [Uses default
charset]
[forbidden-apis] in org.apache.solr.schema.ModifyConfFileTest
(ModifyConfFileTest.java:97)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#readFileToString(java.io.File) [Uses default
charset]
[forbidden-apis] in org.apache.solr.schema.ModifyConfFileTest
(ModifyConfFileTest.java:112)
[forbidden-apis] Scanned 1982 (and 1319 related) class file(s) for forbidden
API invocations (in 1.40s), 7 error(s).
{noformat}
I will commit a fix, too!
was (Author: thetaphi):
Because there was an error in commons-io signatures, some violations were not
detected with 1.3:
{noformat}
-check-forbidden-base:
[forbidden-apis] Reading bundled API signatures: jdk-unsafe-1.7
[forbidden-apis] Reading bundled API signatures: jdk-deprecated-1.7
[forbidden-apis] Reading bundled API signatures: commons-io-unsafe-2.1
[forbidden-apis] Reading API signatures: C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr3\lucene\tools\forbiddenApis\base.txt
[forbidden-apis] Reading API signatures: C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr3\lucene\tools\forbiddenApis\servlet-api
.txt
[forbidden-apis] Loading classes to check...
[forbidden-apis] Scanning for API signatures and dependencies...
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses
default charset]
[forbidden-apis] in org.apache.solr.handler.admin.ShowFileRequestHandler
(ShowFileRequestHandler.java:426)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses
default charset]
[forbidden-apis] in org.apache.solr.handler.admin.ShowFileRequestHandler
(ShowFileRequestHandler.java:450)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses
default charset]
[forbidden-apis] in org.apache.solr.core.TestLazyCores
(TestLazyCores.java:582)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#readFileToString(java.io.File) [Uses default
charset]
[forbidden-apis] in org.apache.solr.handler.PingRequestHandlerTest
(PingRequestHandlerTest.java:103)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#writeStringToFile(java.io.File,java.lang.String)
[Uses
default charset]
[forbidden-apis] in org.apache.solr.AnalysisAfterCoreReloadTest
(AnalysisAfterCoreReloadTest.java:124)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#readFileToString(java.io.File) [Uses default
charset]
[forbidden-apis] in org.apache.solr.schema.ModifyConfFileTest
(ModifyConfFileTest.java:97)
[forbidden-apis] Forbidden method invocation:
org.apache.commons.io.FileUtils#readFileToString(java.io.File) [Uses default
charset]
[forbidden-apis] in org.apache.solr.schema.ModifyConfFileTest
(ModifyConfFileTest.java:112)
[forbidden-apis] Scanned 1982 (and 1319 related) class file(s) for forbidden
API invocations (in 1.40s), 7 error(s).
{noformat}
I will commit a fix, too!
> Update to forbidden-apis 1.4
> ----------------------------
>
> Key: LUCENE-5347
> URL: https://issues.apache.org/jira/browse/LUCENE-5347
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.0, 4.7
>
>
> Forbidden-apis 1.4 is out, new features are:
> - upgrade to ASM 5.0_BETA
> - Improved Java 8 support: support for invokedynamic to methodhandles of
> static methods (used by "::" closures)
> - Reduce memory usage (see LUCENE-4753)
> - some Maven improvements
> - fix signatures of commons-io (thanks [~rcmuir])
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
