[ https://issues.apache.org/jira/browse/LUCENE-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829436#comment-13829436 ]
Areek Zillur commented on LUCENE-5329: -------------------------------------- Thanks Michael for the review! I have addressed your comments. One question though, I was wondering if we have something similar to MultiDocValues for ValueSource (MultValueSource doesnt seem like what I wanted). I think it would be nice if we can get rid of the leaves and starts logic from the DocExprDict too. > Make DocumentDictionary and co more lenient to dirty documents > -------------------------------------------------------------- > > Key: LUCENE-5329 > URL: https://issues.apache.org/jira/browse/LUCENE-5329 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Reporter: Areek Zillur > Attachments: LUCENE-5329.patch, LUCENE-5329.patch, LUCENE-5329.patch, > LUCENE-5329.patch, LUCENE-5329.patch > > > Currently DocumentDictionary errors out whenever any document does not have > value for any relevant stored fields. It would be nice to make it lenient and > instead ignore the invalid documents. > Another "issue" with the DocumentDictionary is that it only allows string > fields as suggestions and binary fields as payloads. When exposing these > dictionaries to solr (via https://issues.apache.org/jira/browse/SOLR-5378), > it is inconvenient for the user to ensure that a suggestion field is a string > field and a payload field is a binary field. It would be nice to have the > dictionary "just work" whenever a string/binary field is passed to > suggestion/payload field. The patch provides one solution to this problem (by > accepting string or binary values), though it would be great if there are any > other solution to this, without making the DocumentDictionary "too flexible" -- This message was sent by Atlassian JIRA (v6.1#6144) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org