[ 
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832698#comment-13832698
 ] 

Andrea Gazzarini commented on SOLR-3191:
----------------------------------------

> the abstract ReturnFields should not have constants. its abstract, it has no 
> syntax. that stuff needs to be moved to an implementation class.

No problem at all, I can reattach the patch

> Separately, SolrReturnFields.java i think has already reached the limit where 
> its totally un-understandable. The original discussion on this issue talked 
> about having a separate implementation, but it seems instead it was all piled 
> into ReturnFields.

Sorry I didn't find those assumptions in this issue. It's all into 
(Solr)ReturnFields class because all the described logic is there. I can 
separate the parser (which from "some" perspectives I could agree with you, 
inner classes complicates the reading) and the builder logic if you think is 
better.

> I think we should make the ReturnFields implementation something that can be 
> plugged into the solrconfig without writing java code and provide 
> alternatives (for example: one that is simple and where the code can be 
> understood)

If things need to be done in this way I can try to do that. Again, I didn't 
because in this issue there's no trace about that "pluggabilty". Also please 
clarify me about what you consider understandable so I can follow that 
direction. 

> field exclusion from fl
> -----------------------
>
>                 Key: SOLR-3191
>                 URL: https://issues.apache.org/jira/browse/SOLR-3191
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Luca Cavanna
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>         Attachments: SOLR-3191.patch
>
>
> I think it would be useful to add a way to exclude field from the Solr 
> response. If I have for example 100 stored fields and I want to return all of 
> them but one, it would be handy to list just the field I want to exclude 
> instead of the 99 fields for inclusion through fl.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to