[ https://issues.apache.org/jira/browse/LUCENE-5373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853871#comment-13853871 ]
Simon Willnauer commented on LUCENE-5373: ----------------------------------------- Thanks for fixing this as well (we spoke offline about this and adrien fixed it before I was able to comment). I actually wonder if RUE.sizeOf(Object) should be test only, it could be in a different patch but this seems very dangerous IMO. There are also classes like AnalyzingSuggester etc. that uses it and I wonder if that can have bad impact on perf. I can already see users calling it in a loop :) > Lucene42DocValuesProducer.ramBytesUsed is over-estimated > -------------------------------------------------------- > > Key: LUCENE-5373 > URL: https://issues.apache.org/jira/browse/LUCENE-5373 > Project: Lucene - Core > Issue Type: Bug > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Attachments: LUCENE-5373.patch, LUCENE-5373.patch, LUCENE-5373.patch, > LUCENE-5373.patch > > > Lucene42DocValuesProducer.ramBytesUsed uses > {{RamUsageEstimator.sizeOf(this)}} to return an estimation of the memory > usage. One of the issues (there might be other ones) is that this class has a > reference to an IndexInput that might link to other data-structures that we > wouldn't want to take into account. For example, index inputs of a > {{RAMDirectory}} all point to the directory itself, so > {{Lucene42DocValuesProducer.ramBytesUsed}} would return the amount of memory > used by the whole directory. -- This message was sent by Atlassian JIRA (v6.1.4#6159) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org