[
https://issues.apache.org/jira/browse/LUCENE-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855493#comment-13855493
]
Dr Oleg Savrasov commented on LUCENE-5375:
------------------------------------------
Hi Michael,
Many thanks for reviewing the patch. I agree that it's rather Lucene issue and
should be covered by appropriate tests.
I see your point about adding cost for correct usage. If I enable assertions
without adding the validateParents, testAdvanceValidationForToChildBjq always
fail, which means that there could be another way for query validation. Let me
investigate it.
Thank you,
Dr Oleg Savrasov,
Community Coordinator,
Grid Dynamics Search team
> ToChildBlockJoinQuery becomes crazy on wrong subquery
> -----------------------------------------------------
>
> Key: LUCENE-5375
> URL: https://issues.apache.org/jira/browse/LUCENE-5375
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/join
> Affects Versions: 4.6
> Reporter: Dr Oleg Savrasov
> Labels: patch
> Attachments: SOLR-5553.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> If user supplies wrong subquery to ToParentBlockJoinQuery it reasonably
> throws IllegalStateException.
> (http://lucene.apache.org/core/4_0_0/join/org/apache/lucene/search/join/ToParentBlockJoinQuery.html
> 'The child documents must be orthogonal to the parent documents: the wrapped
> child query must never return a parent document.'). However
> ToChildBlockJoinQuery just goes crazy silently. I want to provide simple
> patch for ToChildBlockJoinQuery with if-throw clause and test.
> See
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201311.mbox/%3cf415ce3a-ebe5-4d15-adf1-c5ead32a1...@sheffield.ac.uk%3E
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
