[
https://issues.apache.org/jira/browse/SOLR-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-5463:
-----------------------------
Attachment: SOLR-5463.patch
Patch with a few changes added onto Hoss's most recent patch.
{quote}
bq. I accidentally discovered that a blank cursorMark request param is ignored
- is this intentional? I ask because although
CursorMark.parseSerializedTotem("") throws an exception about the bad format of
an empty totem, QueryComponent.prepare() ignores a blank cursorMark param:
Yeah .. that was intentional. My thinking was that from CursorMark's
perspective, attempting to parse a null or blank string was not valid – but
from QueryComponent's perspective, a null or blank string ment "do not
construct a CursorMark object at all"
the basic motivation being that it didn't seem like it should be an error to
have something like /select?q=foo&cursorMark=&... ... but i'm not adamant that
it should work that way.
In fact, thinking about it more, and looking at how some other params (like
start, rows, facet, etc...) deal with blank strings, i agree with you – it
should be an error.
{quote}
I changed the behavior to make blank {{cursorMark}} params raise an error, and
added a couple tests for it to {{CursorMarkTest}}.
I fixed a few misspellings in comments, and removed a few unused imports.
I added a new test {{TestCursorMarkWithoutUniqueKey}}.
I substituted {{CURSOR_MARK_PARAM}} for {{"cursorMark"}}, and
{{CURSOR_MARK_START}} for {{"\*"}} in {{CursorPagingTest}}.
> Provide cursor/token based "searchAfter" support that works with arbitrary
> sorting (ie: "deep paging")
> ------------------------------------------------------------------------------------------------------
>
> Key: SOLR-5463
> URL: https://issues.apache.org/jira/browse/SOLR-5463
> Project: Solr
> Issue Type: New Feature
> Reporter: Hoss Man
> Assignee: Hoss Man
> Attachments: SOLR-5463.patch, SOLR-5463.patch, SOLR-5463.patch,
> SOLR-5463.patch, SOLR-5463__straw_man.patch, SOLR-5463__straw_man.patch,
> SOLR-5463__straw_man.patch, SOLR-5463__straw_man.patch,
> SOLR-5463__straw_man.patch, SOLR-5463__straw_man.patch,
> SOLR-5463__straw_man.patch, SOLR-5463__straw_man.patch,
> SOLR-5463__straw_man.patch, SOLR-5463__straw_man.patch,
> SOLR-5463__straw_man__MissingStringLastComparatorSource.patch
>
>
> I'd like to revist a solution to the problem of "deep paging" in Solr,
> leveraging an HTTP based API similar to how IndexSearcher.searchAfter works
> at the lucene level: require the clients to provide back a token indicating
> the sort values of the last document seen on the previous "page". This is
> similar to the "cursor" model I've seen in several other REST APIs that
> support "pagnation" over a large sets of results (notable the twitter API and
> it's "since_id" param) except that we'll want something that works with
> arbitrary multi-level sort critera that can be either ascending or descending.
> SOLR-1726 laid some initial ground work here and was commited quite a while
> ago, but the key bit of argument parsing to leverage it was commented out due
> to some problems (see comments in that issue). It's also somewhat out of
> date at this point: at the time it was commited, IndexSearcher only supported
> searchAfter for simple scores, not arbitrary field sorts; and the params
> added in SOLR-1726 suffer from this limitation as well.
> ---
> I think it would make sense to start fresh with a new issue with a focus on
> ensuring that we have deep paging which:
> * supports arbitrary field sorts in addition to sorting by score
> * works in distributed mode
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
