Hi again, 1. Please remove the use of sbyte. We pretty much agreed on the list to only expose byte externally, and unless there's a good reason to use sbyte internally let's try and avoid that and the conversions that are needed later.
2. Please send a Pull Request to apache/lucene.net once done Thanks, -- Itamar Syn-Hershko http://code972.com | @synhershko <https://twitter.com/synhershko> Freelance Developer & Consultant Author of RavenDB in Action <http://manning.com/synhershko/> On Mon, Apr 21, 2014 at 8:18 PM, Itamar Syn-Hershko <[email protected]>wrote: > I'll have a look during the next week, thanks for your effort > > -- > > Itamar Syn-Hershko > http://code972.com | @synhershko <https://twitter.com/synhershko> > Freelance Developer & Consultant > Author of RavenDB in Action <http://manning.com/synhershko/> > > > On Mon, Apr 21, 2014 at 2:03 PM, Ramkumar Krishnamoorthy < > [email protected]> wrote: > >> Hi Guys, >> >> I think I have completed porting Contrib/Spatial and Spatial.NTS. >> Did run into couple of questions, but took some educated decisions. >> >> First is the usage of sbyte. I know there were some recent discussion >> about >> the usage of sbyte. And I did run into code, which needed sbyte as a >> param. >> Since there is sbyte used already in the source and just to get it >> compiled >> for now, I have used sbyte. I guess there will be some task in future, if >> needed, to convert all sybte usage back to byte. >> >> The TermsEnumCompatibility and CompatibilityExtensions classes. I couldn't >> find the matching code in Java. And the code was not used anywhere else, >> so >> not sure if we still needed these classes. Again just to get the code >> compiled, I have removed TermsEnumCompatibility class and deleted the >> error >> methods in CompatibilityExtensions. >> >> Hope I made the right decisions. >> >> Guess next step would be someone to review my changes. They can be found >> at. >> https://github.com/cyberram/lucene.net/tree/branch_4x >> >> Cheers, >> Kumar >> > >
