Itamar, I will go ahead and merge this one into master tomorrow evening since I haven't heard from you in a while. I have some more converted / fixed tests to add that are dependent on this PR, so it would be good to continue with the progress. If we end up not wanting to use ICU4NET, we can yank it out without much damage done - the code that was ported was kept pretty much the same as the Java version.
Let me know if I should hold off. On Sat, Dec 26, 2015 at 5:51 PM, laimis <[email protected]> wrote: > Github user laimis commented on the pull request: > > https://github.com/apache/lucenenet/pull/157#issuecomment-167370019 > > I had sometime to port some more code and got through > SegmetingTokenizerBase and its tests. Since it builds on top of the > CharArrayIterator stuff I went ahead and added it to this PR. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
